-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pylint and pytest task #432
Conversation
|
Hi @wumaxd. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vinamra28 fyi: moved PR |
/ok-to-test |
@wumaxd Could you please sign the CLA also 🙂 |
@vinamra28 yes already done so but it is still not showing. I opened already a ticket. |
f0e1d87
to
dd67dad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @vdemeester @chmouel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester, vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- name: PYTHON | ||
description: The used Python version, more precisely the tag for the Python image | ||
type: string | ||
default: "3.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we use 3.8 (whichi s the latest) by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. We could even place there latest as it is the tag for the Python image. Do you think this would make sense or is too confusing having a Python version latest?
Changes
The Tasks can be used to run linting based on the module
pylint
and to execute unit-tests based on the modulepytest
. This is described in issue #364.The Tasks are based on the official Python image and therefore the image tags can be used. The installation of
pylint
andpytest
is done during the task to ensure the possibility to pin the version by using a requirements file.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
File path follows
<kind>/<name>/<version>/name.yaml
Has
README.md
at<kind>/<name>/<version>/README.md
Has mandatory
metadata.labels
-app.kubernetes.io/version
the same as the<version>
of the resourceHas mandatory
metadata.annotations
tekton.dev/pipelines.minVersion
mandatory
spec.description
follows the conventionSee the contribution guide
for more details.